Re: [patch 0/5] scsi/bnx2*: Plug hotplug race, correct locking and simplify hotplug code

From: Martin K. Petersen
Date: Wed Jul 26 2017 - 21:59:24 EST



Thomas,

> The conversion of the cpu hotplug locking to a percpu rwsem does not
> longer allow recursive locking of the hotplug lock.
>
> The BNX2I and BNX2FC drivers install/remove hotplug states with the
> hotplug lock held. The install/removal code acquired the hotplug lock
> as well.
>
> While looking into this, I noticed an interesting hotplug race in the
> BNX2FC driver, which could result in dereferencing a NULL pointer or
> freed and potentially reused memory.
>
> The following series addresses these problems and as a final step on
> top it simplifies the hotplug code in both drivers.

Applied to 4.13/scsi-fixes. Thank you!

--
Martin K. Petersen Oracle Linux Engineering