Re: [PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8

From: Mark Brown
Date: Fri Jul 28 2017 - 10:02:11 EST


On Fri, Jul 28, 2017 at 02:54:59PM +0100, Srinivas Kandagatla wrote:
> On 28/07/17 14:40, Mark Brown wrote:
> > On Wed, Jul 26, 2017 at 02:35:10AM +0200, srinivas.kandagatla@xxxxxxxxxx wrote:
> > > From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>

> > > This patch sets the default internal micbias voltage to 1.8v. This
> > > default value is required for mbhc buttons to work. Also adds dt
> > > bindings to allow the board level file to specify the required default
> > > micbias value.

> > What was the default previously?

> This was set to 2.7v previously for special headsets which have high
> impedance.

So obviously this will break existing users. That's not OK.

Attachment: signature.asc
Description: PGP signature