Re: [PATCH 4/4] clk: sunxi-ng: Wait for lock when using fractional mode

From: Jernej Åkrabec
Date: Mon Jul 31 2017 - 13:18:38 EST


Hi Chen-Yu,

Dne ponedeljek, 31. julij 2017 ob 07:02:18 CEST je Chen-Yu Tsai napisal(a):
> On Mon, Jul 31, 2017 at 12:41 AM, Jernej Skrabec
>
> <jernej.skrabec@xxxxxxxx> wrote:
> > Currently ccu_frac_helper_set_rate() doesn't wait for a lock bit to be
> > set before returning. Because of that, unstable clock may be used.
> >
> > Add a wait for lock in the helper function.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx>
>
> Can you provide a Fixes: tag?

fixes: 89a3dfb78707 ("clk: sunxi-ng: Add fractional lib")

As we discussed on IRC, it is safe to call ccu_helper_wait_for_lock() even on
platforms where lock bit is not present, since it just returns without effect.

Regards,
Jernej

>
> Otherwise this looks good.