Re: security/apparmor/label.c:1498]: (style) Redundant condition

From: John Johansen
Date: Mon Jul 31 2017 - 16:11:47 EST


On 07/17/2017 12:34 AM, David Binderman wrote:
> Hello there,
>
>
> security/apparmor/label.c:1498]: (style) Redundant condition: prev_ns. '!prev_ns || (prev_ns && *prev_ns!=profile->ns)' is equivalent to '!prev_ns || *prev_ns!=profile->ns'
>
> Source code is
>
> if (view != profile->ns &&
> (!prev_ns || (prev_ns && *prev_ns != profile->ns))) {
>

yep, I will add the fix to the next pull request