Re: [PATCH] fs, proc: remove unused variable

From: Michal Hocko
Date: Tue Aug 01 2017 - 08:15:29 EST


On Tue 01-08-17 14:01:20, Arnd Bergmann wrote:
> The last cleanup can go a little further, as shown by this warning:
>
> fs/proc/task_mmu.c: In function 'show_map_vma':
> fs/proc/task_mmu.c:285:28: error: unused variable 'priv' [-Werror=unused-variable]
>
> Fixes: 14ccc3193225 ("fs, proc: remove priv argument from is_stack")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks Arnd! Andrew, could you fold this into
fs-proc-remove-priv-argument-from-is_stack.patch please?

> ---
> fs/proc/task_mmu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 9782dedeead7..186e907187ab 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -282,7 +282,6 @@ show_map_vma(struct seq_file *m, struct vm_area_struct *vma, int is_pid)
> {
> struct mm_struct *mm = vma->vm_mm;
> struct file *file = vma->vm_file;
> - struct proc_maps_private *priv = m->private;
> vm_flags_t flags = vma->vm_flags;
> unsigned long ino = 0;
> unsigned long long pgoff = 0;
> --
> 2.9.0
>

--
Michal Hocko
SUSE Labs