Re: [PATCH v4 1/5] treewide: Consolidate Apple DMI checks
From: Andy Shevchenko
Date: Tue Aug 01 2017 - 08:42:57 EST
On Tue, 2017-08-01 at 15:35 +0300, Andy Shevchenko wrote:
> On Tue, 2017-08-01 at 14:10 +0200, Lukas Wunner wrote:
> > We're about to amend ACPI bus scan with DMI checks whether we're
> > running
> > on a Mac to support Apple device properties in AML.ÂÂThe DMI checks
> > are
> > performed for every single device, adding overhead for everything
> > x86
> > that isn't Apple, which is the majority.ÂÂRafael and Andy therefore
> > request to perform the DMI match only once and cache the result.
> > Outside of ACPI various other Apple DMI checks exist and it seems
> > reasonable to use the cached value there as well.ÂÂRafael, Andy and
> > Darren suggest performing the DMI check in arch code and making it
> > available with a header in include/linux/platform_data/x86/.
> > To this end, add early_platform_quirks() to arch/x86/kernel/quirks.c
> > to perform the DMI check and invoke it from setup_arch().ÂÂSwitch
> > over
> > all existing Apple DMI checks, thereby fixing two deficiencies:
> > * They are now #defined to false on non-x86 arches and can thus be
> > Â optimized away if they're located in cross-arch code.
> > * Some of them only match "Apple Inc." but not "Apple Computer,
> > Inc.",
> > Â which is used by BIOSes released between January 2006 (when the
> > first
> > Â x86 Macs started shipping) and January 2007 (when the company name
> > Â changed upon introduction of the iPhone).
> I like the idea, though I can repeat what I commented on your Github
> We might need to distinguish 2006 vs 2007 Apple hardware. Thus, my
> proposal was to use unsigned int (as bitwise flags) instead of bool
> provide two definitions for the hardware. Set those bits accordingly.
> In case of most of the checks it will be the same as in this patch,
> leaves a flexibility of a choice.
Okay, and you answered there.
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy