Re: [PATCH v3 05/16] ntb: ntb_test: ensure the link is up before trying to configure the mws
From: Jon Mason
Date: Tue Aug 01 2017 - 14:16:31 EST
On Tue, Aug 01, 2017 at 12:09:18PM -0600, Logan Gunthorpe wrote:
> On 01/08/17 12:07 PM, Jon Mason wrote:
> > On Tue, Jul 25, 2017 at 02:57:42PM -0600, Logan Gunthorpe wrote:
> >> After the link tests, there is a race on one side of the test for
> >> the link coming up. It's possible, in some cases, for the test script
> >> to write to the 'peer_trans' files before the link has come up.
> >> To fix this, we simply use the link event file to ensure both sides
> >> see the link as up before continuning.
> >> Signed-off-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>
> > This looks like a bug fix. Assuming this is the case, I can pull it
> > out, add a "Fixes" line, and add it to my bug fixes branch. Is this
> > the case?
> Sure, yup, if you'd like to do that I'm fine with it. Technically, I
> don't think the bug can be triggered until the patches later in the
> series are applied.
Given how trivial it is, I think closing the loop here on this would
be a good thing (and one less patch for your v4).
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@xxxxxxxxxxxxxxxxx
> To post to this group, send email to linux-ntb@xxxxxxxxxxxxxxxxx
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/46065aa6-0fe8-59d5-63dc-3beb66b69154%40deltatee.com.
> For more options, visit https://groups.google.com/d/optout.