Re: [PATCH 2/2] gpio: omap : Add missing clk_unprepare().

From: Grygorii Strashko
Date: Tue Aug 01 2017 - 15:40:19 EST




On 08/01/2017 01:44 AM, Arvind Yadav wrote:
omap_gpio_probe() can fail here and we must disable clock.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
---
drivers/gpio/gpio-omap.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index f8c550de..dbf869f 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1247,6 +1247,8 @@ static int omap_gpio_probe(struct platform_device *pdev)
if (ret) {
pm_runtime_put_sync(dev);
pm_runtime_disable(dev);
+ if (bank->dbck_flag)
+ clk_unprepare(bank->dbck);
return ret;
}


Reviewed-by: Grygorii Strashko <grygorii.strashko@xxxxxx>

--
regards,
-grygorii