Re: [Patch V2] crypto: x86/sha1 : Fix reads beyond the number of blocks passed
From: Herbert Xu
Date: Tue Aug 01 2017 - 22:30:10 EST
On Tue, Aug 01, 2017 at 05:38:32PM -0700, Megha Dey wrote:
> It was reported that the sha1 AVX2 function(sha1_transform_avx2) is
> reading ahead beyond its intended data, and causing a crash if the next
> block is beyond page boundary:
> This patch makes sure that there is no overflow for any buffer length.
> It passes the tests written by Jan Stancek that revealed this problem:
> Jan, can you verify this fix?
> Herbert, can you re-enable sha1-avx2 once Jan has checked it out and
> revert commit b82ce24426a4071da9529d726057e4e642948667 ?
Can you please include the hunk to actually reenable sha1-avx2
in your patch? Thanks!
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt