Re: [RFC PATCH] ARM: dts: stm32: change pinctrl bindings definition

From: Linus Walleij
Date: Wed Aug 02 2017 - 05:32:42 EST

On Mon, Jul 17, 2017 at 1:00 PM, Alexandre TORGUE
<alexandre.torgue@xxxxxx> wrote:

> Initially each pin was declared in "include/dt-bindings/stm32f429-pinfunc.h"
> and each definition contained SOC names (ex: STM32F429_PA9_FUNC_USART1_TX).
> Since this approach was approved, the number of supported MCU has
> increased (STM32F429/STM32F469/STM32f746/STM32H743). To avoid to add a new
> file in "include/dt-bindings" each time a new STM32 SOC arrives I propose
> a new approach which consist to use a macro to define pin muxing in device
> tree. All STM32 DT will use the common macro to define pinmux. Furthermore, it
> will make easy maintenance and integration of new SOC.
> To check that patch generate same dtb than befrore I used dtc binary to (re)generate dts files
> (before and after apply the series).
> Example on stm32f469-disco:
> ./scripts/dtc/dtc -I dtb -O dts -o stm32f469-disco-after.dts
> stm32f469-disco-after.dtb
> ./scripts/dtc/dtc -I dtb -O dts -o stm32f469-disco-before.dts
> stm32f469-disco-before.dtb
> Then diff -u stm32f469-disco-before.dts stm32f469-disco-after.dts

Looks OK to me. I guess it should all be merged into ARM SoC.

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
for the final version.

Linus Walleij