Re: [patch v1 2/2] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver
From: Arnd Bergmann
Date: Wed Aug 02 2017 - 10:56:32 EST
On Wed, Aug 2, 2017 at 4:30 PM, Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
> On 08/02/2017 03:18 PM, Oleksandr Shamray wrote:
>> Driver adds support of Aspeed 2500/2400 series SOC JTAG master controller.
>> +static u32 aspeed_jtag_read(struct aspeed_jtag *aspeed_jtag, u32 reg)
>> + return readl(aspeed_jtag->reg_base + reg);
>> +static void
>> +aspeed_jtag_write(struct aspeed_jtag *aspeed_jtag, u32 val, u32 reg)
>> + writel(val, aspeed_jtag->reg_base + reg);
> Maybe readl_relaxed/writel_relaxed would be enough here.
I'd prefer keeping the regular accessors here, unless this is shown
to be a performance bottleneck, and there is a comment to explain
how the relaxed accessors are determined to be safe.