Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support

From: David.Wu
Date: Thu Aug 03 2017 - 10:03:02 EST


Hi Florian & ChenYu

å 2017/8/3 1:38, Florian Fainelli åé:
This is incorrect in two ways:

- this is a property of the PHY, so it should be documented as such in
Documentation/devicetree/bindings/net/phy.txt so other bindings can
re-use it

- if it was specific to your MAC you would expect a vendor prefix to
this property, which is not there

An alternative way to implement the external/internal logic selection
would be mandate that your Ethernet PHY node have a compatible string
like this:

phy@0 {
compatible = "ethernet-phy-id1234.d400", "ethernet-phy-802.3-c22";
};

Then you don't need this phy-is-internal property, because you can
locate the PHY node by the phy-handle (see more about that in a reply to
patch 10) and you can determine ahead of time whether this PHY is
internal or not based on its compatible string.

We may implement a read_bool_property after parsed phy phandle at stmmac_platform.c, which would make MAC driver know it is a internal phy.