Re: [Xen-devel] [PATCH v2] xen: get rid of paravirt op adjust_exception_frame
From: Juergen Gross
Date: Thu Aug 03 2017 - 10:13:22 EST
On 02/08/17 01:52, Andy Lutomirski wrote:
> On Tue, Aug 1, 2017 at 4:38 PM, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 01/08/2017 20:45, Andy Lutomirski wrote:
>>> Also, IMO it would be nice to fully finish the job. Remaining steps are:
>>> 1. Unsuck the SYSCALL entries on Xen PV.
>>> 2. Unsuck the SYENTER entry on Xen PV.
>>> 3. Make a xen_nmi that's actually correct (should be trivial)
>>> #1 is here:
>> If the
>> /* Zero-extending 32-bit regs, do not remove */
>> movl %eax, %eax
>> comments are to be believed, then the entry logic needs reordering
>> slightly to:
>> movl %eax, %eax /* Zero-extending 32-bit regs, do not remove */
>> pushq %rax /* pt_regs->orig_ax */
> D'oh, right. Juergen, want to make that change?
Hmm, I'd prefer you sending an update which I could test and ack then.