Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc
From: Martin Kaiser
Date: Thu Aug 03 2017 - 12:30:21 EST
Thus wrote Shawn Guo (shawnguo@xxxxxxxxxx):
> On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote:
> > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between
> > the addresses used by tscadc and those in its child nodes (adc, tsc).
> > Without such a mapping, the reg = ... lines in the tsc and adc nodes do
> > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc
> > drivers will then fail since there's no IORESOURCE_MEM.
> > Signed-off-by: Martin Kaiser <martin@xxxxxxxxx>
> Do we need the following Fixes tag?
> Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support")
yes, looks like this has never worked correctly.
If you're ok with the fix, I can add the tag in v2.
> @Markus, we didn't the changes when we were submitting?
Both Markus' and Denis' mail addresses bounced...