Re: [PATCH 1/3] dt-bindings: add "size" property.

From: Rob Herring
Date: Thu Aug 03 2017 - 16:27:42 EST


On Thu, Jul 27, 2017 at 10:13:07PM +0530, divagar.mohandass@xxxxxxxxx wrote:
> From: Divagar Mohandass <divagar.mohandass@xxxxxxxxx>

Please improve the subject. Add size to what?

>
> This adds "size" as optional property for i2c eeproms.
>
> "size" should be mentioned in byte and it should refer
> to the eeprom size. This will be read by the driver and
> used to calculating the number of bytes in read/write calls.
>
> Signed-off-by: Divagar Mohandass <divagar.mohandass@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> index 5696eb5..1436569 100644
> --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
> +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> @@ -32,6 +32,8 @@ Optional properties:
>
> - read-only: this parameterless property disables writes to the eeprom
>
> + - size: total eeprom size in bytes
> +

This should be implied by the compatible string of the eeprom. Why do
you need this?

Rob