Re: [PATCH v5 03/14] drm/fb-helper: separate the fb_setcmap helper into atomic and legacy paths
From: Peter Rosin
Date: Thu Aug 03 2017 - 18:49:42 EST
On 2017-07-14 15:54, Daniel Vetter wrote:
> On Thu, Jul 13, 2017 at 06:25:27PM +0200, Peter Rosin wrote:
>> The legacy path implements setcmap in terms of crtc .gamma_set.
>> The atomic path implements setcmap by directly updating the crtc gamma_lut
>> This has a couple of benefits:
>> - it makes the redundant fb helpers .load_lut, .gamma_set and .gamma_get
>> completely obsolete. They are now unused and subject for removal.
>> - atomic drivers that support clut modes get fbdev support for those from
>> the drm core. This includes atmel-hlcdc, but perhaps others as well?
>> Signed-off-by: Peter Rosin <peda@xxxxxxxxxx>
> Ok, I merged the core parts. I'll wait with the driver stuff for a bit
> more (maybe 1-2 weeks) for more acks. Pls remind me in case I forget to
> pull them in.
> Thanks a lot for doing this, great work!
I don't see the rest it in drm-misc-next and you asked for it, so ping :-)