Re: [PATCH RFC 1/2] spi: pxa2xx: Convert to GPIO descriptor API where possible
From: Mika Westerberg
Date: Fri Aug 04 2017 - 06:28:38 EST
On Fri, Aug 04, 2017 at 12:18:28PM +0200, Jan Kiszka wrote:
> On 2017-08-04 12:10, Mika Westerberg wrote:
> > On Thu, Aug 03, 2017 at 01:40:32PM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
> >> We still need to request/free GPIOs passed via the legacy path of
> >> pxa2xx_spi_chip::gpio_cs, but we can use the gpiod API otherwise.
> >> Consistently use the descriptor API instead of the legacy one.
> >> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
> > There are some PXA2xx platforms under arch/arm/* which use this driver
> > and legacy GPIOs. I wonder if this causes any problems with them?
> > That was one of the reasons I did not convert the whole driver over GPIO
> > descriptors.
> It shouldn't cause problems (famous last words) because I refrained from
> changing the interfaces to them. References that come in as legacy GPIO
> are still treated like that.
OK. I hope someone with a PXA2xx machine could still test it.
Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>