Re: [PATCH v6 1/7] drm/tilcdc: ensure nonatomic iowrite64 is not used
From: Tomi Valkeinen
Date: Fri Aug 04 2017 - 09:03:40 EST
On 03/08/17 21:30, Logan Gunthorpe wrote:
> Add a check to ensure iowrite64 is only used if it is atomic.
> It was decided in  that the tilcdc driver should not be using an
> atomic operation (so it was left out of this patchset). However, it turns
> out that through the drm code, a nonatomic header is actually included:
> is included from include/drm/drm_os_linux.h:9:0,
> from include/drm/drmP.h:74,
> from include/drm/drm_modeset_helper.h:26,
> from include/drm/drm_atomic_helper.h:33,
> from drivers/gpu/drm/tilcdc/tilcdc_crtc.c:19:
> And thus, without this change, this patchset would inadvertantly
> change the behaviour of the tilcdc driver.
I haven't really followed the discussion on this, but if the tilcdc's
use of iowrite64 causes (real) problems/complications elsewhere, I think
we could drop it.
The problem is that the HW has a race issue, and the two registers in
question should be written as close to each other as possible. We
thought a single 64bit write, writing to both registers in one go, would
improve that slightly, compared to two 32 bit writes.
Jyri, correct me if I'm wrong, but we have no proof that it actually
helps, and it might be that even if it helps, the difference is
theoretical. Probably if we ensure the irqs are off when we do two 32
bit writes, we're already close enough to the optimal case.
Description: OpenPGP digital signature