Re: [PATCH 3.18 00/50] 3.18.64-stable review

From: Guenter Roeck
Date: Sat Aug 05 2017 - 15:28:09 EST

On 08/05/2017 08:43 AM, Greg Kroah-Hartman wrote:
On Sat, Aug 05, 2017 at 08:02:17AM +0200, Willy Tarreau wrote:
On Sat, Aug 05, 2017 at 07:55:11AM +0200, Willy Tarreau wrote:
On Fri, Aug 04, 2017 at 07:51:07PM -0700, Greg Kroah-Hartman wrote:
On Fri, Aug 04, 2017 at 07:46:57PM -0700, Greg Kroah-Hartman wrote:
On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote:
On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 3.18.64 release.
There are 50 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Sun Aug 6 23:15:34 UTC 2017.
Anything received after that time might be too late.


Lots of

lib/string.c:31:32: fatal error: asm/word-at-a-time.h

affecting several architectures.


lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'

Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support
zero_bytemask() on alpha and tile"), right? Any other arches failing?

Hm, that doesn't work, do we care about tile? :)

Let me see how deep this hole is, I just wanted to get strscpy into 3.18
to fix a bug...

I suspect you'll need this one which came as part of the strscpy() series
between 4.2 and 4.3 (though I have not tested) :

commit a6e2f029ae34f41adb6ae3812c32c5d326e1abd2
Author: Chris Metcalf <cmetcalf@xxxxxxxxxx>
Date: Wed Apr 29 12:48:40 2015 -0400

Make asm/word-at-a-time.h available on all architectures
Added the x86 implementation of word-at-a-time to the
generic version, which previously only supported big-endian.

OK I just applied it on top of 3.18.64-rc1 and it allowed me to build mips
which previously broke. It will not apply as-is, you'll need to drop the
change for arch/nios2/include/asm/Kbuild, and after that it's OK.

Thanks for that, I've now queued that patch up.

Better, but there are still some errors.

lib/string.c: In function 'strscpy':
lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'

arch/tile/gxio/mpipe.c:46:15: error: conflicting types for 'strscpy'
include/linux/string.h:29:22: note: previous declaration of 'strscpy' was here

Missing patches:

7a5692e6e533 ("arch/powerpc: provide zero_bytemask() for big-endian")
30059d494a72 ("tile: use global strscpy() rather than private copy")