Re: [PATCH v2] drm: dw-hdmi-i2s: add missing company name on Copyright

From: Laurent Pinchart
Date: Mon Aug 07 2017 - 04:55:31 EST


Hi Morimoto-san,

Thank you for the patch.

On Monday 07 Aug 2017 04:09:41 Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> This driver's Copyright is under Renesas Solutions Corp.
> This patch updates the year, because this driver was moved
> into synopsys folder in 2017.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> ---
> v1 -> v2
>
> - update year 2016 -> 2017
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c
> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c index
> b2cf59f..3b7e5c5 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c
> @@ -1,7 +1,8 @@
> /*
> * dw-hdmi-i2s-audio.c
> *
> - * Copyright (c) 2016 Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> + * Copyright (c) 2017 Renesas Solutions Corp.
> + * Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

What does this mean ? The first line makes it clear that you want to assign
copyright ownership to Renesas for the work you've done on this driver. The
second line, however, isn't very clear. If you want to list your e-mail
address as an author or contact person, you should make that explicit:

* Author: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

or

* Contact: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

Or it could be that you have joint copyright ownership with Renesas, or own
parts of the copyright yourself, in which case it should be

* Copyright (c) 2017 Renesas Solutions Corp.
* Copyright (c) 2017 Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

> *
> * This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License version 2 as

--
Regards,

Laurent Pinchart