Re: [v5] wlcore: add missing nvs file name info for wilink8
From: Kalle Valo
Date: Mon Aug 07 2017 - 08:38:22 EST
"Reizer, Eyal" <eyalr@xxxxxx> writes:
> The following commits:
> c815fde wlcore: spi: Populate config firmware data
> d776fc8 wlcore: sdio: Populate config firmware data
It's recommended to use 12 chars when abbreviating commit ids so the
format should be this:
c815fdebef44 wlcore: spi: Populate config firmware data
d776fc86b82f wlcore: sdio: Populate config firmware data
> Populated the nvs entry for wilink6 and wilink7 only while it is
> still needed for wilink8 as well.
> This broke user space backward compatibility when upgrading from older
> kernels, as the alternate mac address would not be read from the nvs that is
> present in the file system (lib/firmware/ti-connectivity/wl1271-nvs.bin)
> causing mac address change of the wlan interface.
> This patch fix this and update the structure field with the same default
> nvs file name that has been used before.
> In addition, some distros hold a default wl1271-nvs.bin in the file
> system with a bogus mac address (deadbeef...) that for a wl18xx device
> also overrides the mac address that is stored inside the device.
> Warn users about this bogus mac address and use a random mac instead
> Cc: stable <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Eyal Reizer <eyalr@xxxxxx>
It's always good to have a fixes line(s) and specify which stable
versions should have the fix. As the commit were first in v4.9-rc1
that's the first version we want this to be included:
Fixes: c815fdebef44 ("wlcore: spi: Populate config firmware data")
Fixes: d776fc86b82f ("wlcore: sdio: Populate config firmware data")
Cc: <stable@xxxxxxxxxxxxxxx> # 4.9+
But if you don't submit a new version I can fix the commit log during