Re: [PATCH] gpio: msic: fix error return code in platform_msic_gpio_probe()

From: Linus Walleij
Date: Mon Aug 07 2017 - 08:58:31 EST


On Fri, Aug 4, 2017 at 12:00 AM, Gustavo A. R. Silva
<gustavo@xxxxxxxxxxxxxx> wrote:

> platform_get_irq() returns an error code, but the gpio-msic driver
> ignores it and always returns -EINVAL. This is not correct, and
> prevents -EPROBE_DEFER from being propagated properly.
>
> Notice that platform_get_irq() no longer returns 0 on error:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
>
> Print and propagate the return value of platform_get_irq on failure.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>

Patch applied.

Yours,
Linus Walleij