Re: [PATCH v06 12/36] x86 uapi asm/signal.h: use __kernel_size_t instead of size_t

From: Arnd Bergmann
Date: Mon Aug 07 2017 - 10:30:53 EST


On Sun, Aug 6, 2017 at 6:44 PM, Mikko Rapeli <mikko.rapeli@xxxxxx> wrote:
> Fixes userspace compilation error:
>
> error: unknown type name âsize_tâ
>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@xxxxxx>
> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: H. Peter Anvin <hpa@xxxxxxxxx>
> ---
> arch/x86/include/uapi/asm/signal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/uapi/asm/signal.h b/arch/x86/include/uapi/asm/signal.h
> index 8264f47cf53e..74346db30758 100644
> --- a/arch/x86/include/uapi/asm/signal.h
> +++ b/arch/x86/include/uapi/asm/signal.h
> @@ -127,7 +127,7 @@ struct sigaction {
> typedef struct sigaltstack {
> void __user *ss_sp;
> int ss_flags;
> - size_t ss_size;
> + __kernel_size_t ss_size;
> } stack_t;
>

In patch 14, you took a different approach based on an earlier comment
of mine, for the same structure. I think we should definitely take the same
approach for signal.h across all architectures, whichever we end up using.

Arnd