Re: [PATCH v2 01/14] perf report: remove code to handle inline frames from browsers
From: Milian Wolff
Date: Mon Aug 07 2017 - 15:22:15 EST
On Montag, 7. August 2017 17:07:10 CEST Arnaldo Carvalho de Melo wrote:
> Em Sun, Aug 06, 2017 at 11:24:33PM +0200, Milian Wolff escreveu:
> > The follow-up commits will make inline frames first-class citizens
> > in the callchain, thereby obsoleting all of this special code.
> So you are removing the feature to then reintroduce it, is that it? That
> is not usual :-\
> Normally we go on replacing bit by bit or have some ifdef, etc, to then
> phase out the old code.
> Perhaps in this case your approach is the best one, still have to look
> at all of it, and it would help if the people behind the original code
> could review this, Yao Jin, can you take a look at this patch series,
Yes, I also did that in v1 of this patch series. Note that I can easily squash
this, if needed. But I personally think for reviewing purposes, having it as
separate patches is far better.
Milian Wolff | milian.wolff@xxxxxxxx | Senior Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
KDAB - The Qt Experts