Re: [PATCH v06 35/36] uapi linux/tls.h: don't include <net/tcp.h> in user space

From: Dmitry V. Levin
Date: Tue Aug 08 2017 - 19:26:03 EST


On Sun, Aug 06, 2017 at 06:44:26PM +0200, Mikko Rapeli wrote:
> It is not needed and not part of uapi headers, but causes
> user space compilation error:
>
> fatal error: net/tcp.h: No such file or directory
> #include <net/tcp.h>
> ^
>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@xxxxxx>
> Cc: Dave Watson <davejwatson@xxxxxx>
> Cc: Ilya Lesokhin <ilyal@xxxxxxxxxxxx>
> Cc: Aviad Yehezkel <aviadye@xxxxxxxxxxxx>
> ---
> include/uapi/linux/tls.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/uapi/linux/tls.h b/include/uapi/linux/tls.h
> index cc1d21db35d8..d87c698623f2 100644
> --- a/include/uapi/linux/tls.h
> +++ b/include/uapi/linux/tls.h
> @@ -37,7 +37,9 @@
> #include <asm/byteorder.h>
> #include <linux/socket.h>
> #include <linux/tcp.h>
> +#ifdef __KERNEL__
> #include <net/tcp.h>
> +#endif

Let's move it to include/net/tls.h instead.


--
ldv

Attachment: signature.asc
Description: PGP signature