Re: [PATCH 1/2] zpool: Delete an error message for a failed memory allocation in zpool_create_pool()

From: Dan Streetman
Date: Wed Aug 16 2017 - 07:19:58 EST


On Mon, Aug 14, 2017 at 7:15 AM, SF Markus Elfring
<elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Mon, 14 Aug 2017 12:57:16 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

Acked-by: Dan Streetman <ddstreet@xxxxxxxx>

> ---
> mm/zpool.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/zpool.c b/mm/zpool.c
> index fd3ff719c32c..fe1943f7d844 100644
> --- a/mm/zpool.c
> +++ b/mm/zpool.c
> @@ -172,7 +172,6 @@ struct zpool *zpool_create_pool(const char *type, const char *name, gfp_t gfp,
>
> zpool = kmalloc(sizeof(*zpool), gfp);
> if (!zpool) {
> - pr_err("couldn't create zpool - out of memory\n");
> zpool_put_driver(driver);
> return NULL;
> }
> --
> 2.14.0
>