Re: [PATCH v2] completion: Document that reinit_completion() must be called after complete_all()

From: Steven Rostedt
Date: Wed Aug 16 2017 - 13:20:26 EST


On Wed, 16 Aug 2017 10:18:27 -0700
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Wed, Aug 16, 2017 at 10:12 AM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > The function complete_all() modifies the completion "done" variable to
> > UINT_MAX, and no other caller (wait_for_completion(), etc) will modify
> > it back to zero. That means that any call to complete_all() must have a
> > reinit_completion() before that completion can be used again.
> >
> > Document this fact by the complete_all() function.
> >
> > Also document that completion_done() will always return true if
> > complete_all() is called.
>
> Ack. Do I take it directly or is it indended for some other tree?
>
> Linus

You can take it, if nobody else wants to.

Thanks!

-- Steve