Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver

[Alexandru Gagniuc]

On 08/16/2017 01:52 PM, Andreas Färber wrote:
> Am 16.08.2017 um 22:50 schrieb Alexandru Gagniuc:
> > On 08/16/2017 02:46 AM, Philipp Zabel wrote:
> > > The reset-simple driver can be used without changes.
> > >
> > > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> >
> > Reviewed-by: Alexandru Gagniuc <alex.g@xxxxxxxxxxxx>
> >
> > > ---
> > >  drivers/reset/Kconfig        |  11 ++---
> > >  drivers/reset/Makefile       |   1 -
> > >  drivers/reset/reset-simple.c |   1 +
> > >  drivers/reset/reset-stm32.c  | 108
> > > -------------------------------------------
> > >  4 files changed, 4 insertions(+), 117 deletions(-)
> > >  delete mode 100644 drivers/reset/reset-stm32.c
> > >
> > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > > index 78a8f6057985b..29f4487c290fc 100644
> > > --- a/drivers/reset/Kconfig
> > > +++ b/drivers/reset/Kconfig
> > > @@ -70,19 +70,14 @@ config RESET_PISTACHIO
> > >
> > >  config RESET_SIMPLE
> > >      bool "Simple Reset Controller Driver" if COMPILE_TEST
> > > -    default ARCH_SOCFPGA || ARCH_SUNXI
> > > +    default ARCH_SOCFPGA || ARCH_STM32 || ARCH_SUNXI
> >
> > If this series gets respun, could you please look into removing the
> > ARCH_ dependency here?
>
> Why?

Because the driver has to keep track of all its users, which is a 
layering violation.

> It's not a dependency, just the default. Doing it here decouples it
> from having to do Kconfig changes in the arm-soc tree as well.

Doing it here allows this list to grow without bounds.

> Regards,
> Andreas