Re: [RFC PATCH 3/7] mmc: sdhci: Add callback to set bus mode

From: Kishon Vijay Abraham I
Date: Thu Aug 17 2017 - 01:31:50 EST


Adrian,

On Tuesday 15 August 2017 01:08 PM, Adrian Hunter wrote:
> On 07/08/17 19:01, Kishon Vijay Abraham I wrote:
>> Add callback to set bus mode in sdhci library so that the
>> controller driver can perform any bus mode specific configurations
>> in the callback function.
>
> A quirk isn't needed. Just hook ->set_ios() e.g.
>
> host->mmc_host_ops.set_ios = sdhci_omap_set_ios;
>
> Then sdhci_omap_set_ios() can call sdhci_set_ios() and then do the bus mode
> setting.

I'm not adding a quirk here.. but I got your point.

Thanks
Kishon