Re: [PATCH] gpu: host1x: fix error return code in host1x_probe()

From: Thierry Reding
Date: Thu Aug 17 2017 - 11:32:25 EST


On Tue, Aug 08, 2017 at 12:08:06AM -0500, Gustavo A. R. Silva wrote:
> platform_get_irq() returns an error code, but the host1x driver
> ignores it and always returns -ENXIO. This is not correct and,
> prevents -EPROBE_DEFER from being propagated properly.
>
> Notice that platform_get_irq() no longer returns 0 on error:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
>
> Print and propagate the return value of platform_get_irq on failure.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> ---
> drivers/gpu/host1x/dev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Thierry

Attachment: signature.asc
Description: PGP signature