Re: [PATCH 2/3] crypto: engine - find request type with cra_type

From: Herbert Xu
Date: Fri Aug 18 2017 - 04:28:56 EST


On Mon, Aug 14, 2017 at 03:17:24PM +0200, Corentin Labbe wrote:
> The current method for finding request type is based on crypto_tfm_alg_type.
>
> But in case of skcipher, it is the same than ablkcipher.
> Using cra_type for this work permits to make the distinction between the two.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@xxxxxxxxx>

I think you misunderstood my suggestion. I'm not saying that
you should use cra_type to distinguish all crypto types, it should
only be used to distinguish ablkcipher from skcipher.

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt