[PATCH] sdhci: remove redundant check of zero slots

From: Colin King
Date: Fri Aug 18 2017 - 08:37:10 EST


From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Slots can never be zero, PCI_SLOTS_INFO_SLOTS returns a value in the
range 0..7; slots is one more than this, 1..8 so cannot be zero and
so the zero check is redundant and can be removed.

Detected by CoverityScan, CID#744269 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
drivers/mmc/host/sdhci-pci-core.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
index 2c853cfa8389..43b2b09131bd 100644
--- a/drivers/mmc/host/sdhci-pci-core.c
+++ b/drivers/mmc/host/sdhci-pci-core.c
@@ -1669,8 +1669,6 @@ static int sdhci_pci_probe(struct pci_dev *pdev,

slots = PCI_SLOT_INFO_SLOTS(slots) + 1;
dev_dbg(&pdev->dev, "found %d slot(s)\n", slots);
- if (slots == 0)
- return -ENODEV;

BUG_ON(slots > MAX_SLOTS);

--
2.11.0