Re: [PATCH 1/3] media: atmel-isc: Not support RBG format from sensor.

[Yang, Wenyou]

Hi Hans,

On 2017/8/21 22:07, Hans Verkuil wrote:
> On 08/17/2017 09:16 AM, Wenyou Yang wrote:
> > The 12-bit parallel interface supports the Raw Bayer, YCbCr,
> > Monochrome and JPEG Compressed pixel formats from the external
> > sensor, not support RBG pixel format.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@xxxxxxxxxxxxx>
> > ---
> >
> >   drivers/media/platform/atmel/atmel-isc.c | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c
> > index d4df3d4ccd85..535bb03783fe 100644
> > --- a/drivers/media/platform/atmel/atmel-isc.c
> > +++ b/drivers/media/platform/atmel/atmel-isc.c
> > @@ -1478,6 +1478,11 @@ static int isc_formats_init(struct isc_device *isc)
> >   	while (!v4l2_subdev_call(subdev, pad, enum_mbus_code,
> >   	       NULL, &mbus_code)) {
> >   		mbus_code.index++;
> > +
> > +		/* Not support the RGB pixel formats from sensor */
> > +		if ((mbus_code.code & 0xf000) == 0x1000)
> > +			continue;
> Am I missing something? Here you skip any RGB mediabus formats, but in patch 3/3
> you add RGB mediabus formats. But this patch prevents those new formats from being
> selected, right?
This patch prevents getting the RGB format from the sensor directly.
The RGB format can be produced by ISC controller by itself.

> Regards,
>
> 	Hans
>
> > +
> >   		fmt = find_format_by_code(mbus_code.code, &i);
> >   		if (!fmt)
> >   			continue;

Best Regards,
Wenyou Yang