Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns

From: Joe Perches
Date: Tue Aug 22 2017 - 22:34:09 EST


On Tue, 2017-08-22 at 18:40 -0700, Greg KH wrote:
> On Thu, Aug 17, 2017 at 02:55:04PM +0300, laurentiu.tudor@xxxxxxx wrote:
> > From: Laurentiu Tudor <laurentiu.tudor@xxxxxxx>
> >
> > Throughout the driver we use == 0 / != 0 to check strcmp() returns except
> > this place, so fix it.
>
> You will just get someone else fixing it as it is not what checkpatch
> recommends, so just leave it as-is please.

No. That's not correct.

checkpatch does not make a recommendation about
style use with the strcmp family of functions.