Re: [PATCH V8 net-next 00/22] Huawei HiNIC Ethernet Driver

From: Arnd Bergmann
Date: Wed Aug 23 2017 - 06:37:38 EST


On Wed, Aug 23, 2017 at 11:31 AM, Aviad Krawczyk
<aviad.krawczyk@xxxxxxxxxx> wrote:
> Hi Arnd,
>
> This is Huawei's PCIE HiNIC card.
>
> I am not familiar with the HiSilicon product and I don't see how
> Huawei's PCIE HiNIC card is connected to the HiSilicon drivers on Linux Tree.
>
> I don't see how it can be shared: different product and different code.

Sharing code was just a wild thought of mine, as I said I had not looked at
whether there is anything that can be shared.

However, simply moving drivers/net/ethernet/huawei/hinic to
drivers/net/ethernet/hisilicon/hinic/ still seems to be the right thing and
is a trivial patch.

It's clear that hinic is made by HiSilicon and that hns/hns3 are used
exclusively in Huawei, and maintained by Huawei developers, so it's
probably just a matter of time before the IP block from the SoC makes
it into a future PCI device or vice versa. Merging the two directories
now makes this easier to handle in the future and (slightly) reduces
the clutter in the top-level drivers/net/ethernet/Kconfig file.

Arnd