Re: [PATCH 0/1] devpts: use dynamic_dname() to generate proc name

From: Stefan Lippers-Hollmann
Date: Thu Aug 24 2017 - 16:24:57 EST


Hi

[ sorry for the re-send, this accidentally only reached you, rather than
the mailing list and the other recipients as well ]

On 2017-08-24, Linus Torvalds wrote:
> On Thu, Aug 24, 2017 at 11:31 AM, Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > It should just do a "return ptm_open_peer(file, tty, (int)arg);" instead.
>
> Here's the actual tested patch. It "WorksForMe(tm)", including the
> TIOCGPTPEER ioctl, and also verified that it gets the pathname right
> in /proc, which was the original problem.
>
> But I did *not* check that pbuilder is still happy. Stefan?

This patch seems to work, ssh, xterm (konsole5), real tty and pbuilder
(creating- and updating the build chroots, just as well as building
several fairly involved packages) are fine with this patch on top of
v4.13-rc6-66-g143c97cc6529 (tested on x86_64).

Thanks a lot
Stefan Lippers-Hollmann