Re: [patch 20/41] x86: Replace access to desc_struct:a/b fields

From: Boris Ostrovsky
Date: Fri Aug 25 2017 - 09:57:27 EST



>
> Index: b/arch/x86/xen/enlighten_pv.c
> ===================================================================
> --- a/arch/x86/xen/enlighten_pv.c
> +++ b/arch/x86/xen/enlighten_pv.c
> @@ -494,7 +494,7 @@ static void __init xen_load_gdt_boot(con
> static inline bool desc_equal(const struct desc_struct *d1,
> const struct desc_struct *d2)
> {
> - return d1->a == d2->a && d1->b == d2->b;
> + return memcmp(d1, d2, sizeof(*d1));
> }

Shouldn't this be !memcmp() ?

-boris