Re: [PATCH v3 3/3] ACPI / PMIC: Add opregion driver for Intel Dollar Cove TI PMIC

From: Takashi Iwai
Date: Fri Aug 25 2017 - 11:38:20 EST


On Fri, 25 Aug 2017 17:24:19 +0200,
Andy Shevchenko wrote:
>
> On Fri, Aug 25, 2017 at 4:44 PM, Takashi Iwai <tiwai@xxxxxxx> wrote:
>
> One really minor nit (fine if it will be ignored):
>
> > +config CHTDC_TI_PMIC_OPREGION
>
> CHTDC_TI_PMIC_OPREGION -> CHT_DC_TI_PMIC_OPREGION

Ah, the world is inconsistent...

> > obj-$(CONFIG_XPOWER_PMIC_OPREGION) += pmic/intel_pmic_xpower.o
> > obj-$(CONFIG_BXT_WC_PMIC_OPREGION) += pmic/intel_pmic_bxtwc.o
> > obj-$(CONFIG_CHT_WC_PMIC_OPREGION) += pmic/intel_pmic_chtwc.o
> > +obj-$(CONFIG_CHTDC_TI_PMIC_OPREGION) += pmic/intel_pmic_chtdc_ti.o
>
> Ditto (as you can notice by above context).

... where the file name is combined.

I really don't mind, too.

Rafael, please let me know if you want a resubmission with this
correction.


thanks,

Takashi