Re: [PATCH 00/14] VME: Adjustments for several function implementations

[Martyn Welch]

On Fri, Aug 25, 2017 at 05:41:13PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Fri, 25 Aug 2017 13:15:43 +0200
> 
> Several update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (14):
>   Delete 11 error messages for a failed memory allocation
>   Improve 11 size determinations
>   Move an assignment in vme_new_dma_list()
>   Adjust 48 checks for null pointers
>   Return directly in two functions
>   fake: Delete an error message for a failed memory allocation in fake_init()
>   fake: Improve five size determinations in fake_init()
>   fake: Adjust 11 checks for null pointers
>   ca91cx42: Delete eight error messages for a failed memory allocation
>   ca91cx42: Improve 12 size determinations
>   ca91cx42: Adjust 14 checks for null pointers
>   tsi148: Delete nine error messages for a failed memory allocation
>   tsi148: Improve 17 size determinations
>   tsi148: Adjust 14 checks for null pointers
> 

Hi Markus,

Thanks for the patches. Other than the minor tweak needed to patch 13,
these are looking good to me.

Martyn

>  drivers/vme/bridges/vme_ca91cx42.c |  73 +++++---------
>  drivers/vme/bridges/vme_fake.c     |  35 +++----
>  drivers/vme/bridges/vme_tsi148.c   |  82 ++++++----------
>  drivers/vme/vme.c                  | 194 ++++++++++++++++---------------------
>  4 files changed, 156 insertions(+), 228 deletions(-)
> 
> -- 
> 2.14.0
>