Re: [PATCH resend] thunderbolt: Fix reset response_type

From: Mika Westerberg
Date: Sun Aug 27 2017 - 09:42:50 EST


On Wed, Aug 16, 2017 at 11:54:17AM +0300, Dan Carpenter wrote:
> There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET)
> instead of just TB_CFG_PKG_RESET. The size of an int is 4 so it's the
> same as TB_CFG_PKG_NOTIFY_ACK.
>
> Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
> Reported-by: Colin King <colin.king@xxxxxxxxxxxxx>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> ---
> Resending with Greg CC'd. This was also:
> Signed-off-by: Andreas Noever <andreas.noever@xxxxxxxxx>
> But I wasn't sure if I should add that tag.

Hi Greg,

Can you pick this fix to your char-misc tree?

Thanks!