Re: [PATCH] mm/vmstats: add counters for the page frag cache

From: Michal Hocko
Date: Fri Sep 01 2017 - 05:21:19 EST


On Fri 01-09-17 12:12:36, Konstantin Khlebnikov wrote:
> IMHO that's too much counters.
> Per-node NR_FRAGMENT_PAGES should be enough for guessing what's going on.
> Perf probes provides enough features for furhter debugging.

I would tend to agree. Adding a counter based on a single debugging
instance sounds like an overkill to me. Counters should be pretty cheep
but this is way too specialized API to export to the userspace.

We have other interfaces to debug memory leaks like page_owner.
--
Michal Hocko
SUSE Labs