Re: [PATCH v4 0/3] arm64: Realtek RTD1295 RTC

From: Alexandre Belloni
Date: Tue Sep 05 2017 - 03:59:20 EST


On 05/09/2017 at 00:53:21 +0200, Andreas FÃrber wrote:
> Hello,
>
> This series adds the RTC for the Realtek RTD1295 SoC.
> Based on my RTD1295 clk series.
>
> There being no public source code for RTD1295, the implementation is based on
> register offsets seen in the vendor DT, as well as older mach-rtk119x code
> published by QNAP.
>
> v4 adds a missing clk_put().
>
> The DT node depends on the clk series for clock index and header.
>
> More experimental patches at:
> https://github.com/afaerber/linux/commits/rtd1295-next
>
> Have a lot of fun!
>
> Cheers,
> Andreas
>
> v3 -> v4:
> * Added clk_put() (Alexandre)
>
> v2 -> v3:
> * Dropped spinlock (Andrew)
> * Improved year_days vs. days_in_year readability
>
> v1 -> v2:
> * Updated rtc driver to no longer use open/release (Alexandre)
> * Cleaned up debug output (Andrew)
> * Avoided COMPILE_TEST division errors (kbuild)
> * Various cleanups and extensions
>
> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> Cc: linux-rtc@xxxxxxxxxxxxxxx
> Cc: Roc He <hepeng@xxxxxxxx>
> Cc: èäç <jiang.liqin@xxxxxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: Andrew Lunn <andrew@xxxxxxx>
>
> Andreas FÃrber (3):
> dt-bindings: rtc: Add Realtek RTD1295
> rtc: Add Realtek RTD1295
> arm64: dts: realtek: Add RTD1295 RTC node
>
> .../devicetree/bindings/rtc/realtek,rtd119x.txt | 16 ++
> arch/arm64/boot/dts/realtek/rtd1295.dtsi | 6 +
> drivers/rtc/Kconfig | 8 +
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-rtd119x.c | 242 +++++++++++++++++++++
> 5 files changed, 273 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/realtek,rtd119x.txt
> create mode 100644 drivers/rtc/rtc-rtd119x.c
>
Applied, thanks.

--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com