Re: [tip:locking/core] locking/refcount: Create unchecked atomic_t implementation

From: Peter Zijlstra
Date: Wed Sep 06 2017 - 04:18:44 EST


On Tue, Sep 05, 2017 at 09:15:36PM +0300, Alexey Dobriyan wrote:

> It is not a policy, just a "grassroot" movement to give people good
> example and wait until someone is annoyed enough to mass convert
> everything. -)

Well, its a mess and I cleaned up the outliers.

> Worked for fs/proc/Makefile .

No, that file is still a mess; the below is what it would take to clean
up according to your preferred pattern.

So go spend an hour or so and write a script that cleans this all up and
convince Linus to run it. Otherwise I really can't be arsed with this
nonsense.

---
diff --git a/fs/proc/Makefile b/fs/proc/Makefile
index 12c6922c913c..8c19ab50eb7f 100644
--- a/fs/proc/Makefile
+++ b/fs/proc/Makefile
@@ -5,29 +5,35 @@
obj-y += proc.o

CFLAGS_task_mmu.o += $(call cc-option,-Wno-override-init,)
+
proc-y := nommu.o task_nommu.o
proc-$(CONFIG_MMU) := task_mmu.o

-proc-y += inode.o root.o base.o generic.o array.o \
- fd.o
-proc-$(CONFIG_TTY) += proc_tty.o
-proc-y += cmdline.o
-proc-y += consoles.o
-proc-y += cpuinfo.o
-proc-y += devices.o
-proc-y += interrupts.o
-proc-y += loadavg.o
-proc-y += meminfo.o
-proc-y += stat.o
-proc-y += uptime.o
-proc-y += version.o
-proc-y += softirqs.o
-proc-y += namespaces.o
-proc-y += self.o
-proc-y += thread_self.o
-proc-$(CONFIG_PROC_SYSCTL) += proc_sysctl.o
-proc-$(CONFIG_NET) += proc_net.o
-proc-$(CONFIG_PROC_KCORE) += kcore.o
-proc-$(CONFIG_PROC_VMCORE) += vmcore.o
-proc-$(CONFIG_PRINTK) += kmsg.o
-proc-$(CONFIG_PROC_PAGE_MONITOR) += page.o
+proc-y += array.o
+proc-y += base.o
+proc-y += cmdline.o
+proc-y += consoles.o
+proc-y += cpuinfo.o
+proc-y += devices.o
+proc-y += fd.o
+proc-y += generic.o
+proc-y += inode.o
+proc-y += interrupts.o
+proc-y += loadavg.o
+proc-y += meminfo.o
+proc-y += namespaces.o
+proc-y += root.o
+proc-y += self.o
+proc-y += softirqs.o
+proc-y += stat.o
+proc-y += thread_self.o
+proc-y += uptime.o
+proc-y += version.o
+
+PROC-$(config_net) += PROC_NET.O
+PROC-$(config_printk) += KMSG.O
+PROC-$(config_proc_kcore) += KCORE.O
+PROC-$(config_proc_page_monitor)+= PAGE.O
+PROC-$(config_proc_sysctl) += PROC_SYSCTL.O
+PROC-$(config_proc_vmcore) += VMCORE.O
+PROC-$(config_tty) += PROC_TTY.O