Re: [PATCH 05/14] kexec_file: factor out crashdump elf header function from x86

From: AKASHI Takahiro
Date: Thu Sep 07 2017 - 22:29:43 EST


On Fri, Aug 25, 2017 at 01:47:49PM +0800, Dave Young wrote:
> On 08/24/17 at 05:18pm, AKASHI Takahiro wrote:
> > prepare_elf_headers() can also be useful for other architectures,
> > including arm64. So let it factored out.
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx>
> > Cc: Dave Young <dyoung@xxxxxxxxxx>
> > Cc: Vivek Goyal <vgoyal@xxxxxxxxxx>
> > Cc: Baoquan He <bhe@xxxxxxxxxx>
> > ---
> > arch/x86/kernel/crash.c | 324 ----------------------------------------------
> > include/linux/kexec.h | 19 +++
> > kernel/crash_core.c | 333 ++++++++++++++++++++++++++++++++++++++++++++++++
>
> It looks better to add these to kexec_file.c instead.

Sure

-Takahiro AKASHI

> Thanks
> Dave