RE: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers.

From: Tristram.Ha
Date: Fri Sep 08 2017 - 21:11:05 EST


> -----Original Message-----
> From: Pavel Machek [mailto:pavel@xxxxxx]
> Sent: Friday, September 08, 2017 1:54 AM
> To: Tristram Ha - C24268
> Cc: andrew@xxxxxxx; muvarov@xxxxxxxxx; nathan.leigh.conrad@xxxxxxxxx;
> vivien.didelot@xxxxxxxxxxxxxxxxxxxx; f.fainelli@xxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Woojung Huh -
> C21699
> Subject: Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to
> add other KSZ switch drivers.
>
> Hi!
>
> > From: Tristram Ha <Tristram.Ha@xxxxxxxxxxxxx>
> >
> > This series of patches is to modify the original KSZ9477 DSA driver so that
> other KSZ switch drivers can be added and use the common code.
> >
>
> Please wrap the lines from time to time...
>
>
> > This patch set is against net-next.
> >
> > drivers/net/dsa/microchip/Makefile | 2 +-
> > drivers/net/dsa/microchip/ksz9477.c | 1317
> ++++++++++++++++++++++++++++++++
>
> We already have ksz_9477_reg.h. So should this be ksz_9477.c for
> consistency?

The product name is KSZ9477 and other switches are also like KSZ####,
so I would prefer to have no separation between KSZ and the product
number. I think the file ksz_9477_reg.h was named that way because
the other files were named ksz_common.c and ksz_spi.c. If need to
we can change the file name.