Re: [PATCH v2 8/8] platform/chrome: cros_ec: sysfs: Modify error handling

From: Benson Leung
Date: Mon Sep 11 2017 - 15:42:11 EST


Hi Thierry,

On Fri, Aug 11, 2017 at 04:23:05PM +0200, Thierry Escande wrote:
> From: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
>
> When accessing a sysfs attribute, if the EC command fails, -EPROTO is
> now returned instead of an error message as it is unlikely an app is
> parsing the error message to do something meaningful.
> Also, this patch makes use of cros_ec_cmd_xfer_status() instead of
> cros_ec_cmd_xfer() so an error message is printed in the syslog.
>
> Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
> Signed-off-by: Thierry Escande <thierry.escande@xxxxxxxxxxxxx>

Looks good. Applied.

--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@xxxxxxxxxx
Chromium OS Project
bleung@xxxxxxxxxxxx

Attachment: signature.asc
Description: Digital signature