Re: [PATCH] tipc: Use bsearch library function

From: David Miller
Date: Mon Sep 11 2017 - 17:30:30 EST


From: Thomas Meyer <thomas@xxxxxxxx>
Date: Sat, 9 Sep 2017 05:18:19 +0200

> @@ -168,6 +169,18 @@ static struct name_seq *tipc_nameseq_create(u32 type, struct hlist_head *seq_hea
> return nseq;
> }
>
> +static int nameseq_find_subseq_cmp(const void *key, const void *elt)
> +{
> + u32 instance = *(u32 *)key;
> + struct sub_seq *sseq = (struct sub_seq *)elt;

Please order local variables from longest to shortest (ie. reverse
christmas tree).

Thank you.