Re: [PATCH -next] pinctrl: sprd: fix build errors and dependencies

From: Linus Walleij
Date: Tue Sep 12 2017 - 03:39:36 EST


On Mon, Sep 4, 2017 at 5:35 PM, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:

> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Fix build errors when CONFIG_OF is not enabled.
> Also, the pinctrl-sprd-sc9860 driver uses functions from the pinctrl-sprd
> driver, so the former should depend on the latter driver.
>
> ../drivers/pinctrl/sprd/pinctrl-sprd.c: In function 'sprd_dt_node_to_map':
> ../drivers/pinctrl/sprd/pinctrl-sprd.c:290:2: error: implicit declaration of function 'pinconf_generic_parse_dt_config' [-Werror=implicit-function-declaration]
> ret = pinconf_generic_parse_dt_config(np, pctldev, &configs,
> ^
> ../drivers/pinctrl/sprd/pinctrl-sprd.c: At top level:
> ../drivers/pinctrl/sprd/pinctrl-sprd.c:844:44: error: array type has incomplete element type
> static const struct pinconf_generic_params sprd_dt_params[] = {
> ^
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Baolin Wang <baolin.wang@xxxxxxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx

Patch applied for fixes.

Yours,
Linus Walleij