Re: [PATCH v3 1/5] staging: typec: tcpm: Drop commented out code

From: Guenter Roeck
Date: Tue Sep 12 2017 - 12:41:31 EST


On Tue, Sep 12, 2017 at 10:38:39AM +0300, Heikki Krogerus wrote:
> On Mon, Sep 11, 2017 at 08:32:04PM -0700, Guenter Roeck wrote:
> > Commented out code can be added as needed. Drop it.
> > Also drop TODO and an obsolete XXX comment.
> >
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> > v2, v3: No change
> >
> > drivers/staging/typec/tcpm.c | 37 +------------------------------------
> > 1 file changed, 1 insertion(+), 36 deletions(-)
>
> Nice! Just to be sure: The idea is to leave tcpci.c in staging, right?
>
Yes, until we get test coverage or Greg gets tired of keeping it there
(in that case we would probably have to drop it).

Guenter