Re: [PATCH] Input: add support for HiDeep touchscreen

From: kbuild test robot
Date: Wed Sep 13 2017 - 03:51:17 EST


Hi Anthony,

[auto build test WARNING on input/next]
[also build test WARNING on v4.13 next-20170912]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Anthony-Kim/Input-add-support-for-HiDeep-touchscreen/20170913-140147
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All warnings (new ones prefixed by >>):

drivers/input/touchscreen/hideep.c: In function 'hideep_update_firmware':
>> drivers/input/touchscreen/hideep.c:575:17: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t {aka const unsigned int}' [-Wformat=]
"file size(%ld) is big more than fw memory size(%d)",
^

vim +575 drivers/input/touchscreen/hideep.c

558
559 static int hideep_update_firmware(struct hideep_ts *ts, const char *fn)
560 {
561 int ret;
562 int retry, retry_cnt = 3;
563 const struct firmware *fw_entry;
564
565 dev_dbg(&ts->client->dev, "enter");
566 ret = request_firmware(&fw_entry, fn, &ts->client->dev);
567
568 if (ret != 0) {
569 dev_err(&ts->client->dev, "request_firmware : fail(%d)", ret);
570 return ret;
571 }
572
573 if (fw_entry->size > ts->fw_size) {
574 dev_err(&ts->client->dev,
> 575 "file size(%ld) is big more than fw memory size(%d)",
576 fw_entry->size, ts->fw_size);
577 release_firmware(fw_entry);
578 return -EFBIG;
579 }
580
581 /* chip specific code for flash fuse */
582 mutex_lock(&ts->dev_mutex);
583
584 ts->dev_state = state_updating;
585
586 /* enter program mode */
587 ret = hideep_enter_pgm(ts);
588
589 if (ret)
590 return ret;
591
592 /* comparing & programming each page, if the memory of specified
593 * page is exactly same, no need to update.
594 */
595 for (retry = 0; retry < retry_cnt; retry++) {
596 hideep_program_nvm(ts, fw_entry->data, fw_entry->size);
597
598 ret = hideep_verify_nvm(ts, fw_entry->data, fw_entry->size);
599 if (!ret)
600 break;
601 }
602
603 if (retry < retry_cnt)
604 dev_dbg(&ts->client->dev, "update success!!!");
605 else
606 dev_err(&ts->client->dev, "update failed!!!");
607
608 SW_RESET_IN_PGM(1000);
609
610 ts->dev_state = state_normal;
611
612 mutex_unlock(&ts->dev_mutex);
613
614 release_firmware(fw_entry);
615
616 return ret;
617 }
618

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip